This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Allow "disassemble 'Foo::bar(char *)'"


>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Paul> It works, but I can't make it backward-compatible and not require a comma
Paul> for two-argument invocation :-(

Yeah.

Paul> If it's acceptable to require comma for two-argument command
Paul> (which IMO it is), I'll update documentation and testsuites, and
Paul> produce a "real" patch.

It is fine by me.

If anybody objects it would be helpful if they would speak up sooner
rather than later.

Paul> +  if (arg[0] == ',')
Paul> +    ++arg;
Paul> +  if (arg[0] == '\0')

You probably want to skip whitespace after the ",".

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]