This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [m68k] correct m68k_convert_register_p for coldfire
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: vladimir at codesourcery dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 6 Nov 2009 14:16:03 +0100 (CET)
- Subject: Re: [m68k] correct m68k_convert_register_p for coldfire
- References: <200911061604.18419.vladimir@codesourcery.com>
> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Fri, 6 Nov 2009 16:04:18 +0300
>
> The m68k_register_type function will return different types for
> fp0 depending on whether we're on Coldfire, or classic m68k.
> However, m68k_convert_register_p contains code such as:
>
> static int
> m68k_convert_register_p (struct gdbarch *gdbarch, int regnum, struct type *type)
> {
> if (!gdbarch_tdep (gdbarch)->fpregs_present)
> return 0;
> return (regnum >= M68K_FP0_REGNUM && regnum <= M68K_FP0_REGNUM + 7
> && type != m68881_ext_type (gdbarch));
> }
>
> and therefore will return true on Coldfire. The attached patch addresses
> this. Is it OK (with the name of changelog file adjusted)?
Looks ok to me.