This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] Clean up opaque.exp


Our test scripts notice when there are multiple tests with the same
name.  One thing they flagged was a strange duplication in opaque.exp.

This script is supposed to run the same tests three times, at
three different points.  Instead it was running some of them four
times, twice at the last point.  I don't see any sign that this was
intentional, and two of them have names like "xyz" and "pqr".  So
I've deleted the duplicate tests.

Tested on x86_64-linux, checked in.

-- 
Daniel Jacobowitz
CodeSourcery

2009-11-02  Daniel Jacobowitz  <dan@codesourcery.com>

	* gdb.base/opaque.exp: Remove duplicate tests and xyz from test name.

---
 gdb/testsuite/gdb.base/opaque.exp |   25 +------------------------
 1 file changed, 1 insertion(+), 24 deletions(-)

Index: gdb-mainline/gdb/testsuite/gdb.base/opaque.exp
===================================================================
--- gdb-mainline.orig/gdb/testsuite/gdb.base/opaque.exp	2009-01-02 21:58:03.000000000 -0800
+++ gdb-mainline/gdb/testsuite/gdb.base/opaque.exp	2009-10-31 07:51:35.000000000 -0700
@@ -181,7 +181,7 @@ gdb_test "whatis afoo" \
 
 gdb_test "ptype afoo" \
     "type = struct foo \{\[\r\n\]+    int a;\[\r\n\]+    int b;\[\r\n\]+\}" \
-    "ptype on opaque struct instance (dynamically) xyz 1"
+    "ptype on opaque struct instance (dynamically) 1"
 
 
 # Ensure that we know the form of an explicit struct foo.
@@ -220,29 +220,6 @@ gdb_test "whatis foop" \
 # Ensure that we know the form of the thing foop points to.
 
 setup_xfail_on_opaque_pointer
-if {!$gcc_compiled} then { setup_xfail "rs6000-*-*" }
-gdb_test "ptype foop" \
-    "type = struct foo \{\[\r\n\]+    int a;\[\r\n\]+    int b;\[\r\n\]+\} \[*\]+" \
-    "ptype on opaque struct pointer (dynamically) 2"
-
-gdb_test "whatis afoo" \
-    "type = struct foo" \
-    "whatis on opaque struct instance (dynamically) 1"
-
-
-# Ensure that we know the form of afoo, an instance of a struct foo.
-
-gdb_test "ptype afoo" \
-    "type = struct foo \{\r\n    int a;\r\n    int b;\r\n\}" \
-    "ptype on opaque struct instance (dynamically) 1"
-
-gdb_test "ptype afoo" \
-    "type = struct foo \{\[\r\n\]*.*int a;\[\r\n\]*.*int b;\[\r\n\]*}\[\r\n\]*" \
-    "ptype on opaque struct instance (dynamically) pqr 1"
-
-
-# Ensure that we know the form of an explicit struct foo.
-
 gdb_test "ptype foop" \
     "type = struct foo \{\[\r\n\]+    int a;\[\r\n\]+    int b;\[\r\n\]+\} \[*\]+" \
     "ptype on opaque struct pointer (dynamically) 2"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]