This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] cleanup: Remove INVALID_ENTRY_POINT (+FR-V modification)
On Saturday 31 October 2009 19:50:53, Jan Kratochvil wrote:
> > /* If there's a valid and known entry point, fills ENTRY_P with it
> > and return true; otherwise return false. */
> > int entry_point_address (CORE_ADDR *entry_p);
>
> Used this one + an error()-calling wrapper.
Nice, thanks.
> 2009-10-31 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Remove INVALID_ENTRY_POINT.
> * frame.c (inside_entry_func): New variable entry_point. Return 0 if
> the entry point is not known.
> * solib-irix.c (enable_break): Likewise.
> * objfiles.c (init_entry_point_info): Stop using INVALID_ENTRY_POINT.
> Initialize EI.ENTRY_POINT_P.
> (entry_point_address): Rename to ...
> (entry_point_address_query): ... a new function. Use EI.ENTRY_POINT_P.
> (entry_point_address): New function.
> (objfile_relocate): Use EI.ENTRY_POINT_P.
> * objfiles.h (struct entry_info): Simplify entry_point comment. New
> field entry_point_p.
> (INVALID_ENTRY_POINT): Remove.
> (entry_point_address_query): New prototype.
> * solib-frv.c (enable_break): Check for NULL SYMFILE_OBJFILE and its
> EI.ENTRY_POINT_P. Return 0 if ".interp" is not found.
Looks OK to me.
--
Pedro Alves