Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h

[Michael Snyder <msnyder at vmware dot com>]

Michael Eager wrote:
> Michael Snyder wrote:
> > Pierre Muller wrote:
> > >   This patch to record.c causes compilation failure on OpenSolaris 
> > > 2009/06
> > >
> > >   The reason is that byteswap.h
> > > is not found.
> > >
> > > The strange thing is that apparently this
> > > is already known in gnulib, 
> > > http://www.gnu.org/software/hello/manual/gnulib/byteswap_002eh.html#byteswap 
> > >
> > > _002eh
> > > Is it that the gdb/gnulib is only a small part of the complete gnulib?
> > >
> > >   Could someone fix this please?
> > Folks, really sorry about all the build failures.
> > Just getting up, give me a few minutes to have coffee.
> > I have an idea that I think will clear this up quickly.
>
> Looks like gcore.o is not linked in.

Can't do it that way -- gcore.o is included (or not)
via the host makefile fragment in NATDEPFILES.

It doesn't work for some hosts, that's why it isn't included for all.

> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/Makefile.in,v
> retrieving revision 1.1103
> diff -u -p -r1.1103 Makefile.in
> --- Makefile.in 21 Oct 2009 14:14:56 -0000      1.1103
> +++ Makefile.in 24 Oct 2009 22:16:44 -0000
> @@ -834,7 +834,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
>          solib.o solib-null.o \
>          prologue-value.o memory-map.o xml-support.o xml-syscall.o \
>          target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \
> -       inferior.o osdata.o gdb_usleep.o record.o \
> +       inferior.o osdata.o gdb_usleep.o record.o gcore.o \
>          jit.o progspace.o
>
>   # Definitions for the syscall's XML files and dir