Re: [PATCH] Fix building gdb-7.0 on x86_64-*-freebsd

[Sérgio Durigan Júnior <sergiodj at linux dot vnet dot ibm dot com>]

On Friday 16 October 2009, Steve Kargl wrote:
> > > +#if (__FreeBSD_version <  800075)
> > >    regcache_raw_supply (regcache, AMD64_DS_REGNUM, &pcb->pcb_ds);
> > >    regcache_raw_supply (regcache, AMD64_ES_REGNUM, &pcb->pcb_es);
> > >    regcache_raw_supply (regcache, AMD64_FS_REGNUM, &pcb->pcb_fs);
> > >    regcache_raw_supply (regcache, AMD64_GS_REGNUM, &pcb->pcb_gs);
> > > +#endif
> 
> The above number 800075 means that any version of FreeBSD
> with __FreeBSD_version less than 800075 will have a struct pcb
> with the pcb_{fged} members.  Any version with __FreeBSD_version
> greater than or equal to 800075 will have these structure members
> removed.  The '8' in 800075 signifies the FreeBSD 8-branch.
> The '75' signifies that 75 changes have occurred on the FreeBSD
> 8-branch that might need special handling.  The removal of the
> struct members occurred on 2009-04-01 while the version number
> was bumped to 800075 on 2009-04-06.  It's the closest version
> number that will work in the '#if (...)'  that will allow the
> gdb-7.x branch to build on all versions of FreeBSD on the amd64
> architecture including the 8.0-Release Candidates (ie., the
> beta releases).


Hi Steve,

Thank you for this patch.  I believe you could add a comment explaining what 
this number means (just like you did above).  What do you think?

Just my two cents, as usual :-).

Regards,

-- 
Sérgio Durigan Júnior
Linux on Power Toolchain - Software Engineer
Linux Technology Center - LTC
IBM Brazil