This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[Obvious] ARI fixes: OP eol rule
- From: "Pierre Muller" <muller at ics dot u-strasbg dot fr>
- To: <gdb-patches at sourceware dot org>
- Date: Tue, 6 Oct 2009 23:31:47 +0200
- Subject: [Obvious] ARI fixes: OP eol rule
I started a series of pretty mechanical fixes...
Hopefully I will not get bored in the middle...
Checked in as obvious.
I couldn't test aix-thread.c
compilation, as this is a native file
and I have no access to such a computer.
2009-10-06 Pierre Muller <muller@ics.u-strasbg.fr>
ARI fix: OP eol rule.
* ada-exp.y (block_lookup): Avoid operator at end of line.
* aix-thread.c (pd_enable): Idem.
* alpha-tdep.c (alpha_next_pc): Idem.
* arm-tdep.c (arm_skip_prologue, arm_scan_prologue): Idem.
(condition_true, coff_sym_is_thumb): Idem.
Index: ada-exp.y
===================================================================
RCS file: /cvs/src/src/gdb/ada-exp.y,v
retrieving revision 1.37
diff -u -p -r1.37 ada-exp.y
--- ada-exp.y 14 Apr 2009 19:04:24 -0000 1.37
+++ ada-exp.y 6 Oct 2009 15:53:54 -0000
@@ -1021,8 +1021,8 @@ block_lookup (struct block *context, cha
name = ada_encode (raw_name);
nsyms = ada_lookup_symbol_list (name, context, VAR_DOMAIN, &syms);
- if (context == NULL &&
- (nsyms == 0 || SYMBOL_CLASS (syms[0].sym) != LOC_BLOCK))
+ if (context == NULL
+ && (nsyms == 0 || SYMBOL_CLASS (syms[0].sym) != LOC_BLOCK))
symtab = lookup_symtab (name);
else
symtab = NULL;
Index: aix-thread.c
===================================================================
RCS file: /cvs/src/src/gdb/aix-thread.c,v
retrieving revision 1.70
diff -u -p -r1.70 aix-thread.c
--- aix-thread.c 14 Aug 2009 00:32:31 -0000 1.70
+++ aix-thread.c 6 Oct 2009 15:53:54 -0000
@@ -893,8 +893,8 @@ pd_enable (void)
stub_name = NULL;
status = pthdb_session_pthreaded (PD_USER, PTHDB_FLAG_REGS,
&pd_callbacks, &stub_name);
- if ((status != PTHDB_SUCCESS &&
- status != PTHDB_NOT_PTHREADED) || !stub_name)
+ if ((status != PTHDB_SUCCESS
+ && status != PTHDB_NOT_PTHREADED) || !stub_name)
return;
/* Set a breakpoint on the returned stub function. */
Index: alpha-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/alpha-tdep.c,v
retrieving revision 1.194
diff -u -p -r1.194 alpha-tdep.c
--- alpha-tdep.c 2 Jul 2009 17:25:52 -0000 1.194
+++ alpha-tdep.c 6 Oct 2009 15:53:55 -0000
@@ -1390,8 +1390,8 @@ alpha_next_pc (struct frame_info *frame,
{
/* Branch format: target PC is:
(new PC) + (4 * sext(displacement)) */
- if (op == 0x30 || /* BR */
- op == 0x34) /* BSR */
+ if (op == 0x30 /* BR */
+ || op == 0x34) /* BSR */
{
branch_taken:
offset = (insn & 0x001fffff);
Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.288
diff -u -p -r1.288 arm-tdep.c
--- arm-tdep.c 11 Sep 2009 18:51:31 -0000 1.288
+++ arm-tdep.c 6 Oct 2009 15:53:57 -0000
@@ -610,14 +610,14 @@ arm_skip_prologue (struct gdbarch *gdbar
if ((inst & 0xfffff000) == 0xe24dd000) /* sub sp, sp, #nn */
continue;
- if ((inst & 0xffffc000) == 0xe54b0000 || /* strb r(0123),[r11,#-nn]
*/
- (inst & 0xffffc0f0) == 0xe14b00b0 || /* strh r(0123),[r11,#-nn]
*/
- (inst & 0xffffc000) == 0xe50b0000) /* str r(0123),[r11,#-nn]
*/
+ if ((inst & 0xffffc000) == 0xe54b0000 /* strb r(0123),[r11,#-nn]
*/
+ || (inst & 0xffffc0f0) == 0xe14b00b0 /* strh r(0123),[r11,#-nn]
*/
+ || (inst & 0xffffc000) == 0xe50b0000) /* str r(0123),[r11,#-nn]
*/
continue;
- if ((inst & 0xffffc000) == 0xe5cd0000 || /* strb r(0123),[sp,#nn] */
- (inst & 0xffffc0f0) == 0xe1cd00b0 || /* strh r(0123),[sp,#nn] */
- (inst & 0xffffc000) == 0xe58d0000) /* str r(0123),[sp,#nn] */
+ if ((inst & 0xffffc000) == 0xe5cd0000 /* strb r(0123),[sp,#nn] */
+ || (inst & 0xffffc0f0) == 0xe1cd00b0 /* strh r(0123),[sp,#nn] */
+ || (inst & 0xffffc000) == 0xe58d0000) /* str r(0123),[sp,#nn] */
continue;
/* Un-recognized instruction; stop scanning. */
@@ -917,16 +917,16 @@ arm_scan_prologue (struct frame_info *th
pv_area_store (stack, regs[ARM_SP_REGNUM], 4, regs[regno]);
}
}
- else if ((insn & 0xffffc000) == 0xe54b0000 || /* strb rx,[r11,#-n]
*/
- (insn & 0xffffc0f0) == 0xe14b00b0 || /* strh rx,[r11,#-n]
*/
- (insn & 0xffffc000) == 0xe50b0000) /* str rx,[r11,#-n]
*/
+ else if ((insn & 0xffffc000) == 0xe54b0000 /* strb rx,[r11,#-n]
*/
+ || (insn & 0xffffc0f0) == 0xe14b00b0 /* strh rx,[r11,#-n]
*/
+ || (insn & 0xffffc000) == 0xe50b0000) /* str rx,[r11,#-n]
*/
{
/* No need to add this to saved_regs -- it's just an arg reg. */
continue;
}
- else if ((insn & 0xffffc000) == 0xe5cd0000 || /* strb rx,[sp,#n]
*/
- (insn & 0xffffc0f0) == 0xe1cd00b0 || /* strh rx,[sp,#n]
*/
- (insn & 0xffffc000) == 0xe58d0000) /* str rx,[sp,#n]
*/
+ else if ((insn & 0xffffc000) == 0xe5cd0000 /* strb rx,[sp,#n]
*/
+ || (insn & 0xffffc0f0) == 0xe1cd00b0 /* strh rx,[sp,#n]
*/
+ || (insn & 0xffffc000) == 0xe58d0000) /* str rx,[sp,#n]
*/
{
/* No need to add this to saved_regs -- it's just an arg reg. */
continue;
@@ -2172,11 +2172,13 @@ condition_true (unsigned long cond, unsi
case INST_LT:
return (((status_reg & FLAG_N) == 0) != ((status_reg & FLAG_V) ==
0));
case INST_GT:
- return (((status_reg & FLAG_Z) == 0) &&
- (((status_reg & FLAG_N) == 0) == ((status_reg & FLAG_V) ==
0)));
+ return (((status_reg & FLAG_Z) == 0)
+ && (((status_reg & FLAG_N) == 0)
+ == ((status_reg & FLAG_V) == 0)));
case INST_LE:
- return (((status_reg & FLAG_Z) != 0) ||
- (((status_reg & FLAG_N) == 0) != ((status_reg & FLAG_V) ==
0)));
+ return (((status_reg & FLAG_Z) != 0)
+ || (((status_reg & FLAG_N) == 0)
+ != ((status_reg & FLAG_V) == 0)));
}
return 1;
}
@@ -5208,11 +5210,11 @@ set_disassembly_style (void)
static int
coff_sym_is_thumb (int val)
{
- return (val == C_THUMBEXT ||
- val == C_THUMBSTAT ||
- val == C_THUMBEXTFUNC ||
- val == C_THUMBSTATFUNC ||
- val == C_THUMBLABEL);
+ return (val == C_THUMBEXT
+ || val == C_THUMBSTAT
+ || val == C_THUMBEXTFUNC
+ || val == C_THUMBSTATFUNC
+ || val == C_THUMBLABEL);
}
/* arm_coff_make_msymbol_special()