This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] testsuite: Avoid auto-import warning on cygwin/mingw


On Thursday 01 October 2009 23:09:42, Pierre Muller wrote:

> Adding --enable-auto-import to link stage
> fixes this problem.
> 
> Is this OK?
> 

I _think_ the idea is fine.  IWBN to have basic tests covering
printing auto-imported vs dllimported variables,
and covering stepping into import-lib'ed dll functions (through
the __imp_ trampolines).

> --- lib/gdb.exp	13 Jul 2009 19:24:18 -0000	1.119
> +++ lib/gdb.exp	1 Oct 2009 22:03:25 -0000
> @@ -1731,7 +1731,10 @@ proc gdb_compile {source dest type optio
>                      lappend options "additional_flags=-L${outdir}"
>                  } elseif { [istarget "mips-sgi-irix*"] } {
>                      lappend options "additional_flags=-rpath ${outdir}"
> -                }
> +                } elseif { ([istarget "*-*-mingw*"]
> +			    || [istarget *-*-cygwin*]) } {
> +		    lappend new_options
> "additional_flags=-Wl,--enable-auto-import"

Did you mean 'lappend options'?

> +		} 
>              }
>  	} elseif { $opt == "shlib_load" } {
>  	    if { ([istarget "*-*-mingw*"]
> 
> 

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]