This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Record segfault
On Tue, Sep 29, 2009 at 10:05, Hui Zhu <teawater@gmail.com> wrote:
> Checked in to 7.0 branch.
>
> Thanks for your help, Joel and Michael.
Ah, sorry for it. And thanks a lot, Marc. :)
Hui
>
> Hui
>
> On Tue, Sep 29, 2009 at 02:16, Michael Snyder <msnyder@vmware.com> wrote:
>> Joel Brobecker wrote:
>>>
>>> Michael,
>>>
>>>> This seems fine to me. ?Please check it into the main branch,
>>>> but don't add it to the release branch unless Joel says it's OK.
>>>
>>> It seems like a worthwhile patch to have, since it fixes a SEGV
>>> (right?). Are you confident about the patch? It seems relatively
>>> straightforward. My only comment is that it eliminates a query
>>> when the user types a record stop - is that desirable? I guess
>>> it is: What are the chances of someone typing "record stop" and
>>> not wanting to stop the recording session?
>>>
>>> In other words: I am ok with the patch being applied to the branch.
>>> If you are, can you give Hui the go-ahead?
>>
>> OK, then, "go ahead", Hui. ? ;-)
>>
>