This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix "show convenience" test


> From: Pedro Alves <pedro@codesourcery.com>
> Date: Wed, 16 Sep 2009 14:16:22 +0100
> Cc: gdb-patches@sourceware.org
> 
> Hmm, I had already approved Paul's similar follow up patch at
> <http://sourceware.org/ml/gdb-patches/2009-04/msg00105.html>.
> I looks like it was waiting for a docs review.

Ouch! sorry about that (binary attachments tend to have this effect on
me ;-).

>  The variable @code{$_siginfo} is bound to extra signal information
> -inspection (@pxref{extra signal information}).
> +inspection (@pxref{extra signal information}). Note that @code{$_siginfo}
> +could be empty. For example, it will be empty before you execute the
> +@code{run} command.
>  @end table

A couple of comments:

  . "the variable ... is bound to extra signal information inspection"
    is awkward wording.  "How about "contains extra signal
    information"?

  . I don't understand the note about it being ``empty''?  What does
    that mean, exactly, and why the example is talking about before
    `run'?  I could understand that it's empty if no signals were
    delivered yet, but what does `run' has to do with this?

  . Please leave two spaces between sentences, not one.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]