Re: [RFA] dwarf2_physname

[Keith Seitz <keiths at redhat dot com>]

On 09/14/2009 03:47 PM, Daniel Jacobowitz wrote:
> I'm really sorry about the rathole.  I expected you'd just ask me to
> do it... you're correct that you are going to get a lot of failures
> with RealView.  I have patches for some of the worst, both in
> testsuite patterns and in GDB proper.  Part of the reason I haven't
> posted them yet, though, is this exact issue - one of the patches in
> our tree for RealView support is the stone-age ancestor of your
> patches :-)
>
> ICC, though, I'm pretty surprised; we get bug reports about people
> using ICC once in a while, and I thought someone had tested it...
>
> Now that you've gone to the trouble, though, let's make the most of
> your work.  Could I persuade you to put the wrappers you needed and
> where to get appropriate compilers onto the GDB wiki?

Yeah, I'll work on that immediately. Of course, that means I have to 
take out all the, umm, colorful language that litters my scripts. O:-)

> Ouch.  Though, why does this make life difficult for the debugger?
> The problem of THIS not being artificial I've seen before - I think
> RealView has the same problem; I may have a patch to work around it -
> but I'm not sure why we care about the name of the parameter in the
> declaration.

The problem is that now we are appending the arguments to the "linkage 
name" that we are computing. So when the dwarf reader sees this, it 
outputs "foo::foo (foo *)" instead of "foo::foo ()". This messes up 
symbol searching in some very interesting ways.

> > Is there anything else you want me to investigate?
>
> No, I'm happy.  Is this patch still current?  If so, I'll review it
> tonight.

Yes, the patch still applies to CVS HEAD.

Let me know if you need anything else.

Keith