This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Make the prec support signal better[4/4] -- amd64-linux
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: teawater at gmail dot com
- Cc: gdb-patches at sourceware dot org, msnyder at vmware dot com
- Date: Wed, 9 Sep 2009 15:52:07 +0200 (CEST)
- Subject: Re: [RFA] Make the prec support signal better[4/4] -- amd64-linux
- References: <daef60380909090629n68903846i1afc07921f30ebad@mail.gmail.com>
> From: Hui Zhu <teawater@gmail.com>
> Date: Wed, 9 Sep 2009 21:29:20 +0800
>
> This patch make amd64-linux support signal record.
> When signal happen, amd64_linux_record_signal will record the change.
> When the signal handler want return, new code in
> "amd64_linux_syscall_record" will record the change.
>
> 2009-09-09 Michael Snyder <msnyder@vmware.com>
> Hui Zhu <teawater@gmail.com>
>
> * amd64-linux-tdep.c (amd64_all_but_ip_registers_record): New
> function.
> (amd64_linux_syscall_record): Call
> amd64_all_but_ip_registers_record if syscall is
> sys_rt_sigreturn.
> (amd64_linux_signal_stack): New enum.
> (amd64_linux_record_signal): New function.
> (amd64_linux_init_abi): Call set_gdbarch_process_record_signal.
Same comments, questions as the i386 counterpart. In addition to
that:
> - record_regs:
> +record_regs:
Not sure if it is spelled out in the coding standards, but emacs' GNU
mode seems to insist on the space you're removing.
Also, looking at this diff it seems there are lots of Linux-specific
constants and functions that have an amd64_ prefix instead of an
amd64_linux_ prefix. In particular the system call numbers. Please
fix that (in a seperate diff).