This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] let record_resume fail immediately on error
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Hui Zhu <teawater at gmail dot com>
- Date: Mon, 7 Sep 2009 23:58:44 -0700
- Subject: Re: [RFA] let record_resume fail immediately on error
- References: <4AA5D713.1060305@vmware.com>
> if (!RECORD_IS_REPLAY)
> {
> if (do_record_message (get_current_regcache ()))
> - {
> - record_resume_error = 0;
> - }
> - else
> - {
> - record_resume_error = 1;
> - return;
> - }
> + internal_error (__FILE__, __LINE__,
> + _("record_resume: do_record_message failed."));
> +
Forgive me if I'm wrong, as I don't know the record.c code at all, but
I cannot help but think that the internal_error is suspicious here.
Why is this an internal_error?
--
Joel