Re: [RFC 1/3] catch syscall -- try 6 -- Source-code modifications

[Eli Zaretskii <eliz at gnu dot org>]

> From: Sérgio_Durigan_Júnior <sergiodj@linux.vnet.ibm.com>
> Date: Fri, 4 Sep 2009 16:00:47 -0300
> 
> +  add_catch_command ("syscall", _("\
> +Catch system calls.\n\
> +The program can take one or more arguments (syscalls names\n\

You meant "The command", right?

> +and/or numbers), in which case it will catch the syscalls\n\
> +provided.  It can also take no arguments, in which case it\n\
> +will catch every syscall.\n\
> +The argument(s) should be the syscall name(s) (if your system\n\
> +has support for it), or the syscall number(s).  If you need\n\
> +more information, please refer to GDB manual."),

This is okay, but too wordy at times.  Suggest the following variant
instead:

    Catch system calls by their names and/or numbers.\n\
    Arguments say which system calls to catch.  If no arguments\n\
    are given, every system call will be caught.\n\
    Arguments, if given, should be one or more system call names\n\
    if your system supports that), or system call numbers."),



My only other comment about the code part is that it would be nice to
have somewhere a description of what a target should do to add support
for this feature.