This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] MI: Error out on -var-create invalid FRAME-ADDR
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Mon, 10 Aug 2009 20:54:52 +0400
- Subject: Re: [patch] MI: Error out on -var-create invalid FRAME-ADDR
- References: <20090810162949.GA9704@host0.dyn.jankratochvil.net>
Jan Kratochvil wrote:
> - Â Â Âif (innermost_block && fi != NULL)
> + Â Â Âif (innermost_block)
> {
> +ÂÂÂÂÂÂÂ Â/* User could specify explicit FRAME-ADDR which was not found but
> +ÂÂÂÂÂÂÂ Â Â EXPRESSION is frame specific and we would not be able to evaluate
> +ÂÂÂÂÂÂÂ Â Â it correctly next time. ÂWith VALID_BLOCK set we must also set
> +ÂÂÂÂÂÂÂ Â Â FRAME and THREAD_ID. Â*/
> +ÂÂÂÂÂÂÂ Âif (fi == NULL)
> +ÂÂÂÂÂÂÂ Â Â{
> +ÂÂÂÂÂÂÂ Â Â Âfprintf_unfiltered (gdb_stderr, "Failed to find the specified"
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â" frame.\n");
> +ÂÂÂÂÂÂÂ Â Â Âreturn NULL;
> +ÂÂÂÂÂÂÂ Â Â}
Why is this fprintf + NULL return, as opposed to error?
Seems OK otherwise.
- Volodya