This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA] Implement -break-commands
- From: "Marc Khouzam" <marc dot khouzam at ericsson dot com>
- To: "Vladimir Prus" <vladimir at codesourcery dot com>, <gdb-patches at sources dot redhat dot com>
- Date: Mon, 27 Jul 2009 10:56:52 -0400
- Subject: RE: [RFA] Implement -break-commands
- References: <200907271303.13335.vladimir@codesourcery.com>
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org
> [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Vladimir Prus
> Sent: Monday, July 27, 2009 5:03 AM
> To: gdb-patches@sources.redhat.com
> Subject: [RFA] Implement -break-commands
>
>
> The below patches implement MI -break-commands. As the name implies,
> it's the same as CLI 'commands'. There are two patches: one
> refactors CLI 'commands' for easier reuse, and the second actually
> adds -break-commands. The patches mostly were derived from Apple
> branch, and then adjusted for CVS HEAD. One functional change I've
> made is that '-break-commands <number>' does not report the list
> of currently set commands -- since -break-info already prints his
> information, it does not seem necessary to add another way. I've
> also added a test and docs.
Nice addition.
>
> The parts of this patch that are not MI are:
> 1. Slight refactoring of cli/cli-script.c
> 2. Slight refactoring of breakpoint.c
>
> I'd appreciate if somebody could review them.
>
> Eli, there's also doc change here, comments appreciated.
I noticed the example in the doc is missing the breakpoint number:
> +-break-command "print v" "continue"
Unless it is optional?
Marc