This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.]

From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: Paul Pluzhnikov <ppluzhnikov at google dot com>, gdb-patches at sources dot redhat dot com
Date: Tue, 23 Jun 2009 20:21:39 +0200
Subject: Re: [patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.]
References: <8ac60eac0905280956v79d9a84apad9a4370212283b9@mail.gmail.com> <m3vdniw74z.fsf@fleche.redhat.com> <8ac60eac0906101839t4d3978fyc1c6d3b3e2eccb6e@mail.gmail.com> <8ac60eac0906101842y2d2fc9fco331cb4336d9508d0@mail.gmail.com> <m3zlc80yxc.fsf@fleche.redhat.com> <8ac60eac0906161342m67c30151lc7f685e0eb36e41f@mail.gmail.com> <m3y6rrzyi7.fsf@fleche.redhat.com> <8ac60eac0906161407s6498913cu5e50e930d599be77@mail.gmail.com> <20090623150322.GA7654@host0.dyn.jankratochvil.net> <m3ab3ylt5i.fsf@fleche.redhat.com>

On Tue, 23 Jun 2009 20:08:41 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> while sure your patch is great it has a regression.  Assuming a regression
> Jan> reproducer needs to link GDB with -lmcheck (but did verify it).
                                                      ^I  ^not

> This is ok.

Checked-in.
	http://sourceware.org/ml/gdb-cvs/2009-06/msg00148.html


> Jan> +		 Try to keep the freeing order compatible with free_objfile.  */
> 
> It seems like it would be nice to have a single function here.

IMO the whole `struct objfile' should replaced by a new one (instead of its
in-place patching).  Which will probably have other dependencies...


Thanks,
Jan

Follow-Ups:
- Re: [patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.]
  - From: Tom Tromey

References:
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Tom Tromey
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Tom Tromey
- Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
  - From: Paul Pluzhnikov
- [patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.]
  - From: Jan Kratochvil
- Re: [patch] Fix a reread_symbols regression by mmap [Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.]
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]