Re: [rfc][patch] Eliminate quadratic slow-down on number of solibs.

[Paul Pluzhnikov <ppluzhnikov at google dot com>]

On Mon, Jun 22, 2009 at 5:43 PM, Ulrich Weigand<uweigand@de.ibm.com> wrote:

> This is OK. ?(Any reason why we can't inline create_overlay_event_breakpoint_1
> into its sole caller?)

No particular reason (it was that way before my 2009-05-14 change).

I've inlined it in the patch below, and that saves a bunch of calls to
update_global_location_list as well :-)

Tested on Linux/x86_64.

>> I also verified that create_overlay_event_breakpoint is not called for
>> each solib (though it is called 7 times, which seems like 6 too many).
>
> Hmm, do you understand where the other calls come from?

I've attached a log (to avoid GMail line wrapping): 4 calls at startup,
3 more when all the solibs are loaded. I haven't debugged the exact reason;
in my reading of the code it should only fire once after all solibs.

Thanks,
-- 
Paul Pluzhnikov

2009-06-22  Paul Pluzhnikov  <ppluzhnikov@google.com>

	Revert 2009-05-14 breakpoint commit (no longer needed).
	* breakpoint.h (breakpoint_re_set_objfile): Remove
	* breakpoint.c (breakpoint_re_set_objfile): Likewise
	(create_overlay_event_breakpoint): Remove objfile parameter,
	iterate over all objfiles.
	* objfiles.c (objfile_relocate): Update.
	* symfile.c (new_symfile_objfile): Likewise.

Attachment: gdb-overlay-bp-20090622-3.txt
Description: Text document

Attachment: gdblog.txt
Description: Text document