Re: [patch] gdbserver: Add support for Z0/Z1 packets

[Pedro Alves <pedro at codesourcery dot com>]

On Monday 22 June 2009 20:38:50, Aleksandar Ristovski wrote:

> > Z0 and Z1 breakpoints also take a 'len' argument, just
> > like Z2-Z4.  You should also pass those down.
> > 
> > But, Let's take a step back --- why not just rename the
> > insert_watchpoint|remove_watchpoint functions to insert_point,remove_point,
> > and relax the type checks in server.c:
> 
> That was my initial implementation, prior to proposing the 
> change. Then I looked at target ops in gdb; there we have 
> two different functions for breakpoint and watchpoint so I 
> followed that logic (even though the logic there seems to be 
> incomplete: there is a pair for hw and non-hw breakponts but 
> only one pair for watchpoints).

That's because software watchpoints aren't "inserted".  Instead,
GDB forces the target to single-step all the way (see
bpstat_should_step calls in infrun.c), and evaluates the
watchpoints expressions for changes at each step.

> But either way is fine with me - just let me know.

I'd prefer the approach I suggested, and worry about splitting
the breakpoints from watchpoints API if/when we actually need it.

-- 
Pedro Alves