This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] not able to set pending breakpoint at qualified C++ function names
- From: Karen Osmond <karen dot osmond at gmail dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 22 Jun 2009 22:28:35 +0100 (BST)
- Subject: Re: [patch] not able to set pending breakpoint at qualified C++ function names
- References: <Pine.LNX.4.64.0902111855170.2518@localhost.localdomain> <m3ws94fezf.fsf@fleche.redhat.com> <Pine.LNX.4.64.0906031434140.32368@localhost.localdomain> <m3bpp3wtwk.fsf@fleche.redhat.com>
- Reply-to: karen dot osmond at gmail dot com
On Thu, 4 Jun 2009, Tom Tromey wrote:
> >>>>> "Karen" == Karen Osmond <karen.osmond@gmail.com> writes:
>
> Karen> 2009-06-03 Karen Osmond <karen.osmond@gmail.com>
> Karen> * linespec.c (find_method): Add new not_found_ptr parameter to
> Karen> bring in line with symtab_from_filename, decode_variable.
> Karen> (decode_compound): Likewise. Also propagate not_found_ptr to
> Karen> find_method.
> Karen> (decode_line_1): Propagage not_found_ptr to decode_compound.
>
> Typo in "propagate".
>
> Karen> (cplusplus_error): Now throws NOT_FOUND_ERROR.
>
> Other than the typo, looks good to me. This is ok once your paperwork
> completes. Send a note to the list when that happens and someone will
> check this in.
Paperwork is now sorted - please could somebody commit?
The patch can be found here:
http://sourceware.org/ml/gdb-patches/2009-06/msg00034.html
And here's the ChangeLog again, with typo corrected:
2009-06-22 Karen Osmond <karen.osmond@gmail.com>
* linespec.c (find_method): Add new not_found_ptr parameter to
bring in line with symtab_from_filename, decode_variable.
(decode_compound): Likewise. Also propagate not_found_ptr to
find_method.
(decode_line_1): Propagate not_found_ptr to decode_compound.
(cplusplus_error): Now throws NOT_FOUND_ERROR.
cheers,
-karen.