This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc][patch] Eliminate quadratic slow-down on number of solibs.


On Mon, Jun 22, 2009 at 10:09 AM, Ulrich Weigand<uweigand@de.ibm.com> wrote:

> Paul Pluzhnikov wrote:
>
>> 2009-05-12  Paul Pluzhnikov  <ppluzhnikov@google.com>
...
> Maybe I'm missing something here, but this seems to break overlay
> support.

Yes, I believe your analysis is correct.

> If you're going to reset only breakpoints
> from one objfile, maybe you should likewise *delete* only breakpoints
> from that objfile?

That sounds like a good approach :-)

Patch below tested on Linux/x86_64 with no new failures.

Unfortunately I don't have any targets that support overlays, so I can't
test this. Did this fail for you on spu? If so, does it pass with this patch?

Thanks,
-- 
Paul Pluzhnikov

2009-06-22  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* breakpoint.c (breakpoint_re_set_one): Add objfile parameter,
	delete overlay breakpoint only in the given objfile.
	(breakpoint_re_set_objfile): Adjust.

Attachment: gdb-overlay-bp-20090622.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]