This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gdb.texinfo patch for -var-list-children (2)


> > I suggest you use unified diffs for patches (cvs diff -u). The
> > default "context" format is some historically-inflicted thing that
> > is hard to read.
> 
> I'm fine with both context and unified diffs.

That's very kind of you to accept context diffs, but I do feel that
most reviewers are more comfortable with unified diffs - so I suggest
we keep asking for unified for future patches. I, for one, cannot
read context diffs. I usually don't ask a resend, and convert the patch
from one format to the next, but I like to ask that future patches
be in unified format.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]