This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[Forward] New ARI warning Sat Jun 20 01:52:57 UTC 2009
- From: "Pierre Muller" <muller at ics dot u-strasbg dot fr>
- To: <gdb-patches at sourceware dot org>
- Cc: "'Tristan Gingold'" <gingold at adacore dot com>
- Date: Sun, 21 Jun 2009 00:48:24 +0200
- Subject: [Forward] New ARI warning Sat Jun 20 01:52:57 UTC 2009
Hi all, hi Tristan,
You patch for Darwin restored ARI "%p" warning
that I removed recently.
This is the message that I got from the nightly script,
quite short and has all the information
-----Message d'origine-----
De : GDB Administrator [mailto:gdbadmin@sourceware.org]
Envoyé : Saturday, June 20, 2009 3:53 AM
À : muller@sourceware.org
Objet : New ARI warning Sat Jun 20 01:52:57 UTC 2009
456a457
> gdb/darwin-nat.c:1775: code: %p: Do not use printf(%p), instead use
printf(%s,paddr()) to dump a target address
gdb/darwin-nat.c:1775: (8, _("darwin_xfer_partial(%s, %d, rbuf=%p,
wbuf=%p) pid=%u\n"),
474,475d474
< gdb/darwin-nat-info.c:765: gettext: trailing new line: A message should
not have a trailing new line
gdb/darwin-nat-info.c:765: error (_("No inferior running\n"));
< gdb/darwin-nat-info.c:784: gettext: trailing new line: A message should
not have a trailing new line
gdb/darwin-nat-info.c:784: error (_("No inferior running\n"));
Tristan, could you test and commit the following fix?
I can't compile this file as I have no machine with Darwin....
Index: darwin-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/darwin-nat.c,v
retrieving revision 1.12
diff -u -p -r1.12 darwin-nat.c
--- darwin-nat.c 19 Jun 2009 14:32:19 -0000 1.12
+++ darwin-nat.c 20 Jun 2009 22:44:30 -0000
@@ -1772,8 +1772,10 @@ darwin_xfer_partial (struct target_ops *
struct inferior *inf = current_inferior ();
inferior_debug
- (8, _("darwin_xfer_partial(%s, %d, rbuf=%p, wbuf=%p) pid=%u\n"),
- core_addr_to_string (offset), (int)len, readbuf, writebuf, inf->pid);
+ (8, _("darwin_xfer_partial(%s, %d, rbuf=%s, wbuf=%s) pid=%u\n"),
+ core_addr_to_string (offset), (int)len,
+ host_address_to_string (readbuf), host_address_to_string (writebuf),
+ inf->pid);
if (object != TARGET_OBJECT_MEMORY)
return -1;
All,
is it OK if I now send the New ARI warning to gdb-testers mailing list?
Pierre Muller
Awk Regression Index "maintainer".