This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] gdbserver: Add qnx target


On Wednesday 17 June 2009 19:50:02, Aleksandar Ristovski wrote:

> configure script generated using autoconf-2.59-r7

Please make sure to use the version from: http://ftp.gnu.org/gnu/autoconf/
Note how your patch regenerated spurious changes.

> ChangeLog:
> * configure.ac (GDBSERVER_LIBS): Add $extra_srv_libs.
> * configure: Regenerated using autoconfg 2.59-r7.
> * Makefile.in (gdbreplay): Add $(GDBSERVER_EXTRA_LIBS) to 
> linking step
> for both gdbserver and gdbreplay.

Okay.  Drop the "using autoconfg foo" bit once you get
yourself the correct version.

Adding an $srv_qnx variable, handled in configure.ac similarly to
srv_mingw would also be acceptable, and could avoid duplication
when you add support for more nto archs.  We now have two ways to
do the same thing...   I don't have preferences for either --- we
could also convert mingw targets to use GDBSERVER_LIBS.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]