This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] * cli/cli-decode.c (apropos_cmd): Fix avoidance of double printing.
On Wed, Jun 17, 2009 at 1:26 PM, Tom Tromey<tromey@redhat.com> wrote:
>>>>>> "Samuel" == Samuel Bronson <naesten@gmail.com> writes:
>
> Samuel> Signed-off-by: Samuel Bronson <naesten@gmail.com>
> Samuel> ---
> Samuel> Âgdb/cli/cli-decode.c | Â Â4 ++--
> Samuel> Â1 files changed, 2 insertions(+), 2 deletions(-)
Oh, oops, I forgot that git uses the first line of the commit message
for the Subject.
> Samuel> - Âint returnvalue=1; /*Needed to avoid double printing*/
> Samuel> + Âint returnvalue=-1; /*Needed to avoid double printing*/
> Samuel> Â Â/* Walk through the commands */
> Samuel> Â Âfor (c=commandlist;c;c=c->next)
> Samuel> Â Â Â{
>
> Shouldn't this reinitialize returnvalue to -1 each time through the
> loop?
Oh ... true! Oops.