This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Improve testsuite for poor expect behavior
- From: Doug Evans <dje at google dot com>
- To: Pierre Muller <muller at ics dot u-strasbg dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 13 Jun 2009 08:52:09 -0600
- Subject: Re: [RFC] Improve testsuite for poor expect behavior
- References: <001201c9ebb1$96414b10$c2c3e130$@u-strasbg.fr>
On Fri, Jun 12, 2009 at 5:00 PM, Pierre Muller<muller@ics.u-strasbg.fr> wrote:
> ?I am trying to run the testsuite in a cygwin environment,
> but for mingw32 or djgpp targets, using native builds of GDB.
>
> [...]
>
> 2009-06-12 ?Pierre Muller ?<muller@ics.u-strasbg.fr>
>
> ? ? ? ?* lib/gdb.exp (fuzzy_newline): New global.
> ? ? ? ?(input_not_from_terminal): New global.
> ? ? ? ?(gdb_input_not_from_terminal): New procedure.
> ? ? ? ?(gdb_proc_unload): Add pattern corresponding to automated answer
> ? ? ? ?if not from terminal.
> ? ? ? ?(delete_breakpoints): Likewise.
> ? ? ? ?(gdb_run_mcd): Likewise.
> ? ? ? ?(gdb_start_cmd): Likewise.
> ? ? ? ?(gdb_internal_error_resync): Likewise.
> ? ? ? ?(gdb_reinitialize_dir): Likewise.
> ? ? ? ?(default_gdb_exit): Likewise.
> ? ? ? ?(gdb_file_cmd): Likewise.
> ? ? ? ?(rerun_to_main): ?Likewise.
> ? ? ? ?(gdb_compile): Also compile set_unbuffered_output
> ? ? ? ?for djgpp target.
> ? ? ? ?(gdb_expect): If fuzzy_newline is set, replace all "\r\n"
> ? ? ? ?by "\r+\n" in expcode.
Hi. I went through the patch.
It's fine with me, fwiw of course.
[I didn't spend _too_ much time vetting the regsub's, but in principle
it seems fine.]