This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Sat, May 30, 2009 at 3:36 PM, Tom Tromey<tromey@redhat.com> wrote: >>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes: > > Tom> It has a number of minor formatting problems, mostly missing spaces > Tom> before open parens. > > Paul> Sorry, these get me every time :-( > > Yeah. Whatever happened to running gdb_indent.sh? Running gdb_indent.sh on these sources produces way too many incorrect indentations :-( I tried my best to have a space before parens this time. > Paul> I would have used bfd_get_file_window(), but it's only compiled in > Paul> when --use-mmap was given to bfd/configure. > Paul> Is there a way to turn that on for GDB? > > Paul> Is it ok to do this in gdb/dwarf2read.c: > Paul> ? if (info->size > 4 * pagesize && (sectp->flags & SEC_RELOC) == 0 > Paul> ? ? ? && (abfd->flags & BFD_IN_MEMORY) == 0) > > I don't know the answer to either of these. > If nobody here knows, I suggest asking on the binutils list. > If they aren't ok, maybe we could add a new BFD function for this. bfd_mmap is now checking in; attached patch uses it. Tested on Linux/x86_64 with no regressions. Thanks, -- Paul Pluzhnikov
Attachment:
bfd-mmap-patch-20090610.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |