This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Fixes for a couple of infrun bugs (thread hop, revert to step thread).
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 9 Jun 2009 15:58:07 -0400
- Subject: Re: Fixes for a couple of infrun bugs (thread hop, revert to step thread).
- References: <200905272300.28249.pedro@codesourcery.com>
[you're explaination just gave me a headache, that's what you get when
you go on vacation for too long :-)]
Coming late on this discussion:
> + /* If the stepping thread exited, then don't try reverting
> + back to it, just keep going. We need to query the target
> + in case it doesn't support thread exit events. */
I'm just wondering if it would make sense to explain why you need to do
that in the comment, or perhaps just explain what would happen if you
didn't. There is such a nice description in the body of your email, and
I'm thinking it's worth having a short summary in the code.
WDYT?
(yes, I know, I'm a comments freak)
--
Joel