This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
cleanup last traces of NATIVE_XFER_AUXV
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Date: Sun, 7 Jun 2009 20:08:57 +0100
- Subject: cleanup last traces of NATIVE_XFER_AUXV
No nm.h file defines this anymore. Tested by building a solaris
gdb, and by building an --enable-targets=all x86_64-linux hosted gdb.
Checked in.
--
Pedro Alves
20009-06-07 Pedro Alves <pedro@codesourcery.com>
* auxv.c (procfs_xfer_auxv): Change type of the `object' argument
to enum target_object. Cleanup comments.
* auxv.h: Include "target.h". Cleanup comments to not mention
NATIVE_XFER_AUXV anymore.
---
gdb/auxv.c | 11 ++++-------
gdb/auxv.h | 21 ++++++---------------
2 files changed, 10 insertions(+), 22 deletions(-)
Index: src/gdb/auxv.c
===================================================================
--- src.orig/gdb/auxv.c 2009-06-07 19:48:26.000000000 +0100
+++ src/gdb/auxv.c 2009-06-07 20:02:42.000000000 +0100
@@ -33,16 +33,13 @@
#include <fcntl.h>
-/* This function is called like a to_xfer_partial hook,
- but must be called with TARGET_OBJECT_AUXV.
- It handles access via /proc/PID/auxv, which is the common method.
- This function is appropriate for doing:
- #define NATIVE_XFER_AUXV procfs_xfer_auxv
- for a native target that uses inftarg.c's child_xfer_partial hook. */
+/* This function is called like a to_xfer_partial hook, but must be
+ called with TARGET_OBJECT_AUXV. It handles access via
+ /proc/PID/auxv, which is a common method for native targets. */
LONGEST
procfs_xfer_auxv (struct target_ops *ops,
- int /* enum target_object */ object,
+ enum target_object object,
const char *annex,
gdb_byte *readbuf,
const gdb_byte *writebuf,
Index: src/gdb/auxv.h
===================================================================
--- src.orig/gdb/auxv.h 2009-06-07 19:48:23.000000000 +0100
+++ src/gdb/auxv.h 2009-06-07 20:02:24.000000000 +0100
@@ -21,14 +21,9 @@
#ifndef AUXV_H
#define AUXV_H
-/* See "include/elf/common.h" for the definition of valid AT_* values. */
-
-
-/* Avoid miscellaneous includes in this file, so that it can be
- included by nm-*.h for the procfs_xfer_auxv decl if that is
- used in NATIVE_XFER_AUXV. */
-struct target_ops; /* Forward declaration. */
+#include "target.h"
+/* See "include/elf/common.h" for the definition of valid AT_* values. */
/* Read one auxv entry from *READPTR, not reading locations >= ENDPTR.
Return 0 if *READPTR is already at the end of the buffer.
@@ -48,16 +43,12 @@ extern int target_auxv_search (struct ta
/* Print the contents of the target's AUXV on the specified file. */
extern int fprint_target_auxv (struct ui_file *file, struct target_ops *ops);
-
-/* This function is called like a to_xfer_partial hook,
- but must be called with TARGET_OBJECT_AUXV.
- It handles access via /proc/PID/auxv, which is the common method.
- This function is appropriate for doing:
- #define NATIVE_XFER_AUXV procfs_xfer_auxv
- for a native target that uses inftarg.c's child_xfer_partial hook. */
+/* This function is called like a to_xfer_partial hook, but must be
+ called with TARGET_OBJECT_AUXV. It handles access via
+ /proc/PID/auxv, which is a common method for native targets. */
extern LONGEST procfs_xfer_auxv (struct target_ops *ops,
- int /* enum target_object */ object,
+ enum target_object object,
const char *annex,
gdb_byte *readbuf,
const gdb_byte *writebuf,