This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: TR: ARI warning list change Fri May 29 01:53:26 UTC 2009
- From: Tom Tromey <tromey at redhat dot com>
- To: "Pierre Muller" <muller at ics dot u-strasbg dot fr>
- Cc: <vladimir at codesourcery dot com>, "'Thiago Jung Bauermann'" <bauerman at br dot ibm dot com>, <gdb-patches at sourceware dot org>
- Date: Fri, 05 Jun 2009 12:51:32 -0600
- Subject: Re: TR: ARI warning list change Fri May 29 01:53:26 UTC 2009
- References: <000001c9e02a$034bb030$09e31090$@u-strasbg.fr>
- Reply-to: tromey at redhat dot com
>>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:
Pierre> Here is another example of the email that is generated
Pierre> by my patch to update-web-ari.
Pierre> It seems like you have forgotten a bunch of _()
Pierre> macros.
Sorry about that. I am going to commit the appended patch to fix the
problem.
Pierre> A possible improvement would be to send this message directly to
Pierre> people that committed a change to the sources that
Pierre> generated a new warning.
Pierre> Is it possible to extract the commits from the last 24 hours
Pierre> to find out to whom this kind of message should be sent?
With CVS, it can be done, but very easily.
Tom
2009-06-05 Tom Tromey <tromey@redhat.com>
* varobj.c (update_dynamic_varobj_children): Wrap error text in
_().
(install_visualizer): Likewise.
(varobj_set_visualizer): Likewise.
Index: varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/varobj.c,v
retrieving revision 1.132
diff -u -r1.132 varobj.c
--- varobj.c 4 Jun 2009 21:56:22 -0000 1.132
+++ varobj.c 5 Jun 2009 18:49:57 -0000
@@ -850,19 +850,19 @@
if (!children)
{
gdbpy_print_stack ();
- error ("Null value returned for children");
+ error (_("Null value returned for children"));
}
make_cleanup_py_decref (children);
if (!PyIter_Check (children))
- error ("Returned value is not iterable");
+ error (_("Returned value is not iterable"));
iterator = PyObject_GetIter (children);
if (!iterator)
{
gdbpy_print_stack ();
- error ("Could not get children iterator");
+ error (_("Could not get children iterator"));
}
make_cleanup_py_decref (iterator);
@@ -879,7 +879,7 @@
inner = make_cleanup_py_decref (item);
if (!PyArg_ParseTuple (item, "sO", &name, &py_v))
- error ("Invalid item from the child list");
+ error (_("Invalid item from the child list"));
if (PyObject_TypeCheck (py_v, &value_object_type))
{
@@ -1383,7 +1383,7 @@
if (!visualizer && var->children_requested)
varobj_list_children (var);
#else
- error ("Python support required");
+ error (_("Python support required"));
#endif
}
@@ -1454,7 +1454,7 @@
if (! pretty_printer)
{
gdbpy_print_stack ();
- error ("Could not evaluate visualizer expression: %s", visualizer);
+ error (_("Could not evaluate visualizer expression: %s"), visualizer);
}
if (pretty_printer == Py_None)
@@ -1467,7 +1467,7 @@
do_cleanups (back_to);
#else
- error ("Python support required");
+ error (_("Python support required"));
#endif
}