This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: ptid from core section
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Aleksandar Ristovski <aristovski at qnx dot com>
- Date: Wed, 3 Jun 2009 15:41:48 +0100
- Subject: Re: ptid from core section
- References: <4A23F9FF.8040708@qnx.com>
On Monday 01 June 2009 16:55:43, Aleksandar Ristovski wrote:
> In corelow.c we have several architecture specific lines for
> determining ptid from core section. The same for getting
> section name given inferior_ptid.
>
> This patch moves architecture specific parts into two new
> functions: gdbarch_ptid_from_core_section and
> gdbarch_core_section_name_from_ptid.
>
> They replace Pedro's gdbarch_core_reg_section_encodes_pid
> since predicate is now redundant.
>
> I haven't added diffs for generated gdbarch.h/c, I would
> like to get your thoughts about this first.
As we talked about on IRC the other day, a better solution
could require a redesign and normalization of how bfd exposes these
thread/lwp/process ids. In principle, this change is fine
with me, but it seems you forgot to attach the patch. :-)
It would be nice if you included the nto bits in the
patch, so we can see how this helps in your case, so
that people can check upfront if this change is
sufficient and good.
--
Pedro Alves