This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Build failure fix: Python troubles on non-python targets...
- From: Tom Tromey <tromey at redhat dot com>
- To: "Pierre Muller" <muller at ics dot u-strasbg dot fr>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 28 May 2009 09:32:02 -0600
- Subject: Re: [RFA] Build failure fix: Python troubles on non-python targets...
- References: <001001c9df7b$8f2a3810$ad7ea830$@u-strasbg.fr>
- Reply-to: tromey at redhat dot com
>>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:
Pierre> On DJGPP,
Pierre> I now get this failure:
[...]
Sorry about that.
Pierre> The following two changes fixes compilation for me:
Pierre> Is this patch OK?
Nearly...
Pierre> +
Pierre> +#ifdef HAVE_PYTHON
Pierre> +
Pierre> #include "python.h"
Pierre> #include "python-internal.h"
This should unconditionally include python.h. So, the conditional
needs to be moved down a few lines. It is ok to include python.h even
if Python is not available; and in this case it is desirable so that
the declarations are picked up (and thus checked against the
definitions).
Ok with that change. Thanks.
Tom