This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Wed, 27 May 2009 19:16:12 -0600
- Subject: Re: [patch] Use mmap instead of obstack_alloc for dwarf debug sections.
- References: <20090527001157.934BD76BC0@localhost>
- Reply-to: tromey at redhat dot com
>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:
I like this patch quite a bit.
It has a number of minor formatting problems, mostly missing spaces
before open parens.
Paul> + caddr_t retbuf = mmap (0, map_length, PROT_READ, MAP_PRIVATE,
Paul> + fileno ((FILE *)abfd->iostream),
Paul> + pg_offset);
I don't know for sure, but I assume that it is not valid in general to
cast iostream like this.
Tom