This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Can we get rid of go32_stop? (and its normal_stop call?)


On Friday 01 May 2009 17:54:21, Eli Zaretskii wrote:

> I patched my snapshot with your changes, let me run with it for some
> time and see if anything goes wrong.  You can commit the changes in
> the meantime.

Thanks, that's great.

> Out of curiosity: why was normal_stop sentenced to death?

It relies on hidden global state as input parameters, e.g.,
get_last_target_status(), stopped_by_random_signal, stop_stack_dummy,
that breakpoints hadn't been removed yet, etc., so it's not exactly
correct to call it at random times.  Also importantly (and that's
what I was after) not having it being called from outside of the core
of inferior control makes it easier to work on cleaning up and
refactoring bits of infrun.c.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]