This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix a buglet in elfread.c
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: gdb-patches at sourceware dot org, Frank Middleton <f dot middleton at apogeect dot com>
- Date: Thu, 30 Apr 2009 14:54:22 -0700
- Subject: Re: [patch] Fix a buglet in elfread.c
- References: <20090430164806.7DED819C4E1@localhost>
> 2009-04-30 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * elfread.c (elf_symtab_read): Don't assume .data and .rodata
> are present.
Looks good to me. Please go ahead and apply.
I tested this patch on sparc-solaris 2.8 with -gstabs+, since this
seems to be related to stabs. I don't think we can really test
this part of the code with a GCC compiler, but perhaps it's is
still exercised throught the loading of some of the Solaris shared
libraries. We did our best, and we had 2 pairs of eyes looking at it,
so it should be fine.
--
Joel