This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch] Fix a buglet in elfread.c
- From: ppluzhnikov at google dot com (Paul Pluzhnikov)
- To: gdb-patches at sourceware dot org
- Cc: Frank Middleton <f dot middleton at apogeect dot com>
- Date: Thu, 30 Apr 2009 09:48:06 -0700 (PDT)
- Subject: [patch] Fix a buglet in elfread.c
Greetings,
GDB appears to make unwarranted assumptions about presence of .data,
.rodata in and ELF image.
In http://sourceware.org/ml/gdb/2009-04/msg00228.html you can see an image
on Solaris which has .rodata, but no .data, and this causes
elfread.c:366: internal-error: sect_index_data not initialized
when using /usr/lib/libXau.so.6 from Solaris snv103 (SunOS 5.11) for SPARC.
Attached patch fixes that.
OK?
--
Paul Pluzhnikov
2009-04-30 Paul Pluzhnikov <ppluzhnikov@google.com>
* elfread.c (elf_symtab_read): Don't assume .data and .rodata
are present.
Index: elfread.c
===================================================================
RCS file: /cvs/src/src/gdb/elfread.c,v
retrieving revision 1.76
diff -u -p -u -r1.76 elfread.c
--- elfread.c 3 Jan 2009 05:57:51 -0000 1.76
+++ elfread.c 30 Apr 2009 15:03:41 -0000
@@ -427,10 +427,11 @@ elf_symtab_read (struct objfile *objfile
int max_index;
size_t size;
- max_index
- = max (SECT_OFF_BSS (objfile),
- max (SECT_OFF_DATA (objfile),
- SECT_OFF_RODATA (objfile)));
+ max_index = SECT_OFF_BSS (objfile);
+ if (objfile->sect_index_data > max_index)
+ max_index = objfile->sect_index_data;
+ if (objfile->sect_index_rodata > max_index)
+ max_index = objfile->sect_index_rodata;
/* max_index is the largest index we'll
use into this array, so we must