This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/commit] prefer in-tree libiconv over the system libiconv
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 22 Apr 2009 09:22:01 -0700
- Subject: Re: [RFA/commit] prefer in-tree libiconv over the system libiconv
- References: <20090420183619.GB5858@adacore.com> <m3fxg32fk6.fsf@fleche.redhat.com> <20090420213559.GS2904@adacore.com> <20090421210032.GF23807@adacore.com> <m3bpqpzi6p.fsf@fleche.redhat.com>
> Joel> The diff seems awful, but all I did was move the block for ../libiconv
> Joel> up before we check for iconv in the libc. And I made us check iconv
> Joel> in libc only if we haven't found iconv in ../libiconv.
>
> The code change looks fine FWIW.
Thanks! I'll let this patch sit for a week, and then check it in,
if there aren't any objection.
I'm starting to use this method for my own builds, and I have to say
that it is really convenient. Dropped the libiconv sources in my source
tree once, and never have to remember how to configure GDB, or where
the lib[...] install is. I'd like to do the same for libexpat. Thoughts?
--
Joel