Re: needed-list fails in libiberty

[Eli Zaretskii <eliz at gnu dot org>]

> Cc: joseph@codesourcery.com, gcc-patches@gcc.gnu.org,
>         gdb-patches@sources.redhat.com
> From: Ian Lance Taylor <iant@google.com>
> Date: Wed, 15 Apr 2009 06:49:48 -0700
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> > 2009-04-14  Eli Zaretskii  <eliz@gnu.org>
> >> >
> >> > 	* Makefile.in (needed-list): Target removed (not used in GCC
> >> > 	3.0 and later).  All references deleted.
> >> 
> >> This is OK if you've done a clean bootstrap on a primary platform.

I bootstrapped yesterday's SVN on this platform:

  Linux fencepost 2.6.16.29-xen #1 SMP Wed Dec 6 07:32:36 EST 2006 x86_64 GNU/Linux

> For a patch like this only the libiberty testsuite need be run.

After a successful bootstrap, I typed "make -C libiberty check", and
the test ran to completion without any errors.

Here's again the patch I suggest (this time including the removal of 2
obsolete Awk scripts).  As I don't have write access, could someone
please commit it?

Thanks.

2009-04-16  Eli Zaretskii  <eliz@gnu.org>

	* Makefile.in (needed-list): Target removed (not used in GCC
	3.0 and later).  All references deleted.
	(mostlyclean): Remove references to needed.awk and needed2.awk.


--- libiberty/Makefile.in~	2009-04-15 14:07:06.825412329 -0400
+++ libiberty/Makefile.in	2009-04-15 15:15:03.574853288 -0400
@@ -100,7 +100,7 @@
 SUBDIRS = testsuite
 
 # FIXME: add @BUILD_INFO@ once we're sure it works for everyone.
-all: stamp-picdir $(TARGETLIB) needed-list required-list all-subdir
+all: stamp-picdir $(TARGETLIB) required-list all-subdir
 	@: $(MAKE) ; exec $(MULTIDO) $(FLAGS_TO_PASS) multi-do DO=all
 
 .PHONY: check installcheck
@@ -377,22 +377,6 @@
 	mv -f $(DESTDIR)$(tooldir)/lib/$(MULTIOSDIR)/$(TARGETLIB)n $(DESTDIR)$(tooldir)/lib/$(MULTIOSDIR)/$(TARGETLIB)
 	@$(MULTIDO) $(FLAGS_TO_PASS) multi-do DO=install
 
-# needed-list is used by libstdc++.  NEEDED is the list of functions
-# to include there.  Do not add anything LGPL to this list; libstdc++
-# can't use anything encumbering.
-NEEDED = atexit calloc memchr memcmp memcpy memmove memset rename strchr \
-	 strerror strncmp strrchr strstr strtol strtoul tmpnam vfprintf vprintf \
-	 vfork waitpid bcmp bcopy bzero
-needed-list: Makefile
-	rm -f needed-list; touch needed-list; \
-	for f in $(NEEDED); do \
-	  for g in $(LIBOBJS) $(EXTRA_OFILES); do \
-	    case "$$g" in \
-	      *$$f*) echo $$g >> needed-list ;; \
-	    esac; \
-	  done; \
-	done
-
 # required-list was used when building a shared bfd/opcodes/libiberty
 # library.  I don't know if it used by anything currently.
 required-list: Makefile
@@ -440,8 +424,8 @@
 # multiple times, hence our explicit recursion with an empty SUBDIRS.
 mostlyclean: mostlyclean-subdir
 	-rm -rf *.o pic core errs \#* *.E a.out
-	-rm -f needed.awk needed2.awk errors dummy needed-list config.h stamp-*
-	-rm -f $(CONFIG_H) $(NEEDED_LIST) stamp-picdir
+	-rm -f errors dummy config.h stamp-*
+	-rm -f $(CONFIG_H) stamp-picdir
 	-rm -f libiberty.aux libiberty.cp libiberty.cps libiberty.fn libiberty.ky
 	-rm -f libiberty.log libiberty.tmp libiberty.tps libiberty.pg
 	-rm -f libiberty.pgs libiberty.toc libiberty.tp libiberty.tpl libiberty.vr