This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix crash on Linux 2.4 when threaded program exits
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Joel Brobecker <brobecker at adacore dot com>
- Date: Wed, 1 Apr 2009 19:42:39 +0100
- Subject: Re: [RFA] Fix crash on Linux 2.4 when threaded program exits
- References: <20090401182220.GG16605@adacore.com>
On Wednesday 01 April 2009 19:22:20, Joel Brobecker wrote:
> 2009-04-01 Joel Brobecker <brobecker@adacore.com>
>
> * linux-nat.c (linux_nat_filter_events): Do not delete the lwp if
> this is the last one.
>
> Tested on x86-linux (with a 2.4.21 Linux kernel). It fixes ~25 failures.
> Tested on x86_64-linux (with a 2.6 kernel). No regression.
>
> Does this look correct?
Yes, this is OK.
The comments about ntpl and thread exit notifications on nptl
are confusing to a reader considering Linux 2.6. They could do
with a:
s/In the nptl thread model/In the nptl thread model on Linux 2.4/.
wait_lwp does mention this 2.4 + backported nptl artifact explicitly.
--
Pedro Alves