This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Fix MI timings
On Monday 09 March 2009 21:36:34, Pedro Alves wrote:
> On Monday 09 March 2009 21:32:25, Vladimir Prus wrote:
> > +void mi_print_timing_maybe ();
>
> ^ (void) here too, please.
>
> Also, it's redundant, but the only other function declared
> in the header marks it explicitly as "extern", you may want
> to do the same for consistency.
>
I was touching this file and noticed this patch went it without
the '(void)'. Evil as I am, I went ahead and checked in the
patch below. Muahahaha!!1 :-)
--
Pedro Alves
2009-03-17 Pedro Alves <pedro@codesourcery.com>
* mi/mi-main.h (mi_print_timing_maybe): Add strict prototype,
declare as extern.
---
gdb/mi/mi-main.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: src/gdb/mi/mi-main.h
===================================================================
--- src.orig/gdb/mi/mi-main.h 2009-03-17 05:05:10.000000000 +0000
+++ src/gdb/mi/mi-main.h 2009-03-17 05:05:42.000000000 +0000
@@ -26,11 +26,11 @@ extern void mi_load_progress (const char
unsigned long total_sent,
unsigned long grand_total);
+extern void mi_print_timing_maybe (void);
+
extern char *current_token;
extern int running_result_record_printed;
-void mi_print_timing_maybe ();
-
#endif