This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] How to get target_ops from to_kill method?


> > Yeah, fixing them all would be a lot of work, indeed. How about
> > we decide that, from now on, all new methods should have a target_ops
> > parameter as their first argument? Do you think that it would be
> > a good thing? We can fix the others as needed...
> 
> I can't see it a bad thing, so I'm on for it.

Excellent. So, unless I hear any objection, I'll add a comment at
the beginning of the target_ops structure that details this new
requirement.

> > > I much prefer this version over the other.  It's incremental, and
> > > doesn't add any hack or reference to the current_target global.
> > 
> > Me too. I haven't checked it in, yet, because it would become
> > unecessary if we added the target_ops parameter to the to_kill
> > method, which I can take care of.... What do you think?
> 
> If you're willing to, it sounds very good to me.  :-)

Hey, you're not the only one who's allowed to break other's builds,
you know? ;-) I'll take care of that asap. (I have to switch to
something else for the rest of the afternoon)

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]