This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] testsuite: Fix a racy FAIL on gdb.base/multi-forks.exp


On Sat, 14 Mar 2009 00:00:33 +0100, Joel Brobecker wrote:
> > gdb/testsuite/
> > 2009-03-13  Jan Kratochvil  <jan.kratochvil@redhat.com>
> > 
> > 	Fix a racy FAIL.
> > 	* gdb.base/multi-forks.exp (continue_to_exit_bp_loc): New function with
> > 	code from `follow parent, print pids'.
> > 	(`follow child, print pids', `follow parent, print pids'): Call it.
> > 	Replace `gdb_test "break..."' by gdb_breakpoint.
> 
> This seems pretty reasonable to me...

Checked-in: http://sourceware.org/ml/gdb-cvs/2009-03/msg00090.html


> I am so sorry to be picking on your comments. I very much appreciate
> the fact that you spend the time writing them, especially since most
> people tend to not write comments. In this case, this comments also
> sounds strange. Here is a suggestion:

Used your text.  I will give the same effort on the comments as on user
visible texts.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]