This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Create src/gdb/common, move signals.c there.
- From: Daniel Jacobowitz <drow at false dot org>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 27 Feb 2009 17:14:17 -0500
- Subject: Re: [RFC] Create src/gdb/common, move signals.c there.
- References: <20090205215202.CE0251C7A1E@localhost>
On Thu, Feb 05, 2009 at 01:52:02PM -0800, Doug Evans wrote:
> Some code is shared between gdb and gdbserver, and over time more
> code will be shared. And I think the lack of explicit sharing
> is complicating progress.
I, personally, do not think that sharing code between gdb and
gdbserver is very useful. There's no defined common API that shared
code could rely on, and the internals are pretty different.
> This patch does these things:
>
> 1) Create src/gdb/common, and adds -I's to $(src)/common to the Makefiles.
> 2) Pull the duplicate decls of the functions in signals.c out of
> gdb/target.h and gdbserver/server.h and put them in common/gdb_signals.h.
> 3) Move signals/signals.c to common/signals.c, and cleans up signals.c
> a bit.
This patch seems fine on its own merits, though.
> - maybe(!) move regformats to common, though it's big enough
> and standalone enough that I don't have an opinion on it
Not sure what the point of this would be, that code is just for
gdbserver.
--
Daniel Jacobowitz
CodeSourcery