Re: [RFA] fix cygwin gdb.base/find.exp failures

[Doug Evans <dje at google dot com>]

On Mon, Jan 26, 2009 at 2:32 AM, Pierre Muller <muller@ics.u-strasbg.fr> wrote:
>  I am still running the testsuite using
> expect version 5.26 from 2003,
> because I never managed to get expect 5.43
> to run on cygwin... (no more pty available error :( )
>
>  This version has some specific troubles, limitations
> or features that make some tests fail using that version
> while they should not (or does it have to do with the
> tcl version... not really sure, I remember having read once
> something about the multiple evaluation differences
> for quoted versus braced expressions...).
>
>  gdb.base/find.exp is such an example.
>
>  By a one line patch, I fixed the 17 failures I get otherwise
> for this test.
>
> gdb/testsuite/ChangeLog entry:
>
> 2009-01-26  Pierre Muller  <muller@ics.u-strasbg.fr>
>
>        * gdb.base/find.exp: Set newline variable
>        using quotes instead of braces to fix cygwin failures.
>
>
>
> cvs diff -up gdb/testsuite/gdb.base/*
> Index: gdb/testsuite/gdb.base/find.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/find.exp,v
> retrieving revision 1.4
> diff -u -p -r1.4 find.exp
> --- gdb/testsuite/gdb.base/find.exp     3 Jan 2009 05:58:03 -0000       1.4
> +++ gdb/testsuite/gdb.base/find.exp     26 Jan 2009 10:24:04 -0000
> @@ -54,7 +54,7 @@ gdb_expect {
>
>  set hex_number {0x[0-9a-fA-F][0-9a-fA-F]*}
>  set history_prefix {[$][0-9]* = }
> -set newline {[\r\n]*}
> +set newline "\[\r\n\]*"
>  set pattern_not_found "${newline}Pattern not found\[.\]"
>  set one_pattern_found "${newline}1 pattern found\[.\]"
>  set two_patterns_found "${newline}2 patterns found\[.\]"

Someone else will have to formally approve the patch, but I tested it
on i386-linux, and it works there so the patch is fine with me.