This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Remove call to deprecated_update_frame_pc_hack from normal_stop
- From: Daniel Jacobowitz <drow at false dot org>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 23 Jan 2009 16:07:19 -0500
- Subject: Re: Remove call to deprecated_update_frame_pc_hack from normal_stop
- References: <200901232016.07213.pedro@codesourcery.com>
On Fri, Jan 23, 2009 at 08:16:06PM +0000, Pedro Alves wrote:
> Do you think there's still a case for having this around?
>
> We always decrement the PC first thing in handle_inferior_event,
> before reiniting the cache.
>
> Of all other cases I can think of that end up calling normal_stop,
> if we end up here without a call to reinit_frame_cache, this hack
> is wrong/insuficient anyway.
>
> While I'm at it, I can eliminate deprecated_update_frame_pc_hack
> and deprecated_update_frame_base_hack, by inlining them in their
> only caller left.
>
> Tested on x86_64-linux.
This is fine with me.
--
Daniel Jacobowitz
CodeSourcery