This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Remove call to deprecated_update_frame_pc_hack from normal_stop


On Fri, Jan 23, 2009 at 08:16:06PM +0000, Pedro Alves wrote:
> Do you think there's still a case for having this around?
> 
> We always decrement the PC first thing in handle_inferior_event,
> before reiniting the cache.
> 
> Of all other cases I can think of that end up calling normal_stop,
> if we end up here without a call to reinit_frame_cache, this hack
> is wrong/insuficient anyway.
> 
> While I'm at it, I can eliminate deprecated_update_frame_pc_hack
> and deprecated_update_frame_base_hack, by inlining them in their
> only caller left.
> 
> Tested on x86_64-linux.

This is fine with me.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]