This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Remove deprecated_safe_get_selected_frame call from read_var_value
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: drow at false dot org (Daniel Jacobowitz)
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 15 Jan 2009 16:39:51 +0100 (CET)
- Subject: Re: [rfc] Remove deprecated_safe_get_selected_frame call from read_var_value
Daniel Jacobowitz wrote:
> On Wed, Jan 14, 2009 at 04:31:51PM +0100, Ulrich Weigand wrote:
> >
> > > ChangeLog:
> > >
> > > * value.h (address_of_variable): Add prototype.
> > > (locate_var_value): Remove prototype.
> > >
> > > * findvar.c (read_var_value): Do not attempt to default frame
> > > to selected frame.
> > > (locate_var_value): Remove function.
> > > * valops.c (value_of_variable): Retrieve selected frame for
> > > symbols that require a frame when called with NULL block.
> > > * valops.c (address_of_variable): New function.
> > >
> > > * eval.c (evaluate_subexp_for_address): Call address_of_variable
> > > instead of calling locate_var_value.
> > > (evaluate_subexp_with_coercion): Likewise.
> >
> > I've noticed a couple of tests that are now obsolete. Please consider
> > the following patch instead. Re-tested on powerpc-linux.
>
> Looks reasonable to me.
Thanks for the review!
I've checked this in now.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com