This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: fix pretty-printing in "bt full"
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 22 Dec 2008 09:00:24 +0400
- Subject: Re: RFA: fix pretty-printing in "bt full"
- References: <m3myexxjv2.fsf@fleche.redhat.com>
> I think this looks nicer, because the contents of "a" are indented
> underneath "a".
I agree.
> 2008-12-15 Tom Tromey <tromey@redhat.com>
>
> * stack.c (print_block_frame_locals): Print spaces, not tabs.
> Pass indentation level to print_variable_value.
> (print_frame_arg_vars): Update.
> * value.h (print_variable_value): Update.
> * printcmd.c (print_variable_value): Add 'indent' argument. Use
> common_val_print.
> * f-valprint.c (info_common_command): Update.
Just one comment: How about letting print_variable_value do all
the indenting instead of having the caller indent the first line?
I think that would simplify the usage as well as the description.
What do you think?
The rest looks OK to me.
Thanks,
--
Joel