This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] [2/7] infrun cleanup: miscellaneous cleanups


On Sunday 07 December 2008 01:23:40, Pedro Alves wrote:
> On Sunday 07 December 2008 00:17:36, Ulrich Weigand wrote:
> >    if (!ecs->wait_some_more)
> >      {
> > -      struct inferior *inf = find_inferior_pid (ptid_get_pid (ecs->ptid));
> > +      
> Please change this bit to:
> 
> - ? ? ?struct inferior *inf = find_inferior_pid (ptid_get_pid (ecs->ptid));
> + ? ? ?struct inferior *inf = find_inferior_pid (ptid_get_pid (inferior_ptid));

Looking again, it would be more correct (and safest as it doesn't change current
behaviour) to leave it as ptid_get_pid(ecs->ptid) in this patch, and change it
to ptid_get_pid (ptid) in the last patch (the event ptid).

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]