This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] "lazily" allocate the raw content of lazy values
>>>>> "Jerome" == Jerome Guitton <guitton@adacore.com> writes:
Jerome> The new version of the patch is in attachment, re-tested against the
Jerome> testsuite. Promoting this message to RFA now. OK to apply?
Just FYI -- I can't approve or reject it.
However, it seems sound to me.
A couple more formatting nits, sorry about that.
Jerome> + /* Actual contents of the value. Target byte-order. NULL or not valid if
Jerome> + lazy is nonzero. */
Jerome> + gdb_byte *contents;
GNU style requires 2 spaces after a ".".
Jerome> +void
Jerome> +allocate_value_contents (struct value *val)
Jerome> +{
Jerome> + if (!val->contents)
Jerome> + {
Jerome> + val->contents = (gdb_byte *) xzalloc (TYPE_LENGTH (val->enclosing_type));
Jerome> + }
No need for the braces here.
Tom