This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [commit] dwarf2read.c (typename_concat): avoid segv

From: Daniel Jacobowitz <drow at false dot org>
To: Doug Evans <dje at google dot com>, gdb-patches at sourceware dot org
Date: Fri, 24 Oct 2008 14:47:19 -0400
Subject: Re: [commit] dwarf2read.c (typename_concat): avoid segv
References: <20081024182614.58B191C7947@localhost> <20081024184301.GA7759@caradoc.them.org>

On Fri, Oct 24, 2008 at 02:43:01PM -0400, Daniel Jacobowitz wrote:
> If NULL values are valid, this change is definitely not correct.
> You've changed a NULL prefix and "foo" suffix from "foo" to "::foo".

"Definitely" is too strong... I see that we differed with and without
an obstack :-(

-- 
Daniel Jacobowitz
CodeSourcery

Follow-Ups:
- Re: [commit] dwarf2read.c (typename_concat): avoid segv
  - From: Doug Evans

References:
- [commit] dwarf2read.c (typename_concat): avoid segv
  - From: Doug Evans
- Re: [commit] dwarf2read.c (typename_concat): avoid segv
  - From: Daniel Jacobowitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]